-
Notifications
You must be signed in to change notification settings - Fork 511
Execute interpolated Pester describe blocks if PSES signals that it is possible #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…a hint that they should upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const answer = await vscode.window.showErrorMessage( | ||
"This Describe block's TestName parameter cannot be evaluated. " + | ||
"This Describe block's TestName parameter cannot be evaluated in versions of Pester before 4.6.0. " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like this is a little more actionable?
"This Describe block's TestName parameter cannot be evaluated in versions of Pester before 4.6.0. " + | |
"This Describe block's TestName could not be parsed. Either try again with Pester 4.6.0 or higher, or remove any inline parameters in your TestName." + |
Thoughts @rkeithhill?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, something like this but it might ne even better if the ending is more like or remove any variable expressions in the Describe block name
@bergmeister See PR #1776 as an alternative approach. By moving the Pester version detection logic into an |
I propose that we close this PR in favor of PR #1776 |
PR Summary
Fixes #1710
This PR requires this PSES to be merged as a pre-requisite as PSES sends us info if the installed Pester version supports this.
In the future it would be nice to enhance the prompt to ask the user to install the latest version of Pester for them if they are on an old version, for the moment, I only added some info to make them aware.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets.Please mark anything not applicable to this PR
NA
.WIP:
to the beginning of the title and remove the prefix when the PR is ready