-
Notifications
You must be signed in to change notification settings - Fork 511
[Ignore] Prep for 2.0.0-preview.1 release #1716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ignore] Prep for 2.0.0-preview.1 release #1716
Conversation
CHANGELOG.md
Outdated
Finally, click `Reload` in order to refresh VSCode. | ||
|
||
If you already have the PowerShell extension please disable it to use the Powershell Preview extension. | ||
To disable the PowerShell extension find it in the extensions Marketplace and click `Disable`. Please note that it is important to only have either the PowerShell extension or the PowerShell Preview extension endabled at one time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marketplace? Shouldn't this be something like "... find it in the Extensions sidebar view, specifically under the list of Enabled extensions. Right-click on the PowerShell extension and select Disable
."`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the wording!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be a few issues to close once this is out the door
CHANGELOG.md
Outdated
#### Preview builds of the PowerShell extension are now available in VSCode | ||
|
||
We are excited to announce the PowerShell Preview extension in the VSCode marketplace! | ||
The PowerShell Preview extension allows users on Windows PowerShell 5.1 and newer to get and test the latest updates to the PowerShell extension and comes with some exciting features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May need to put Windows PowerShell 5.1 and PowerShell 6.1 and up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure everyone knows "it works on Core" (but I've omitted Core above because of personal brand preference... I dunno!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
CHANGELOG.md
Outdated
|
||
The PowerShell Preview extension is a substitute for the PowerShell extension so both the PowerShell extension and the PowerShell Preview extension should not be enabled at the same time. | ||
|
||
By having a preview channel, which only supports Windows Powershell 5.1 and newer, in addition to our existing stable channel, we can get new features out faster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line is trying to say two things, which are:
With the preview channel, we will be able to get feedback on recent additions to the extension, allowing us to develop better features without compromising stability.
NOTE: As of version 2.0.0, the PowerShell extension no longer supports PowerShell 3 or 4. This is a requirement of the PSReadLine integration, and is discussed at length here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also give this feedback in the Blog post
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CHANGELOG.md
Outdated
The PowerShell Preview extension is a substitute for the PowerShell extension so | ||
both the PowerShell extension and the PowerShell Preview extension should not be enabled at the same time. | ||
|
||
By having a preview channel, which only supports Windows Powershell 5.1 and PowerShell Core 6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this needs the which only supports...
clause. Taking it out makes the statement much more cohesive I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By having a preview channel, which only supports Windows Powershell 5.1 and PowerShell Core 6, | |
By having a preview channel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
PR Summary
This PR is mostly for documentation purposes. After this, I'll change the version back to just
2.0.0
and get rid of all the preview stuff.Note that this PR doesn't have the following changes:
This PR also has a one line fix to update the
preview
property in thepackage.json
Related PR: PowerShell/PowerShellEditorServices#861
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets.Please mark anything not applicable to this PR
NA
.WIP:
to the beginning of the title and remove the prefix when the PR is ready