Skip to content

PSSA 1.19.0 settings #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2020
Merged

Conversation

bergmeister
Copy link
Contributor

@bergmeister bergmeister commented Apr 30, 2020

PR Summary

Pending PSSA 1.19.0 release and this PSES PR, but I tested it locally: PowerShell/PowerShellEditorServices#1280

  • Split the powershell.codeFormatting.trimWhitespaceAroundPipe setting into 2 settings since PSSA has changed the behaviour of the current setting to only add the missing white space around pipes but not remove any more. For trimming of redundant whitespace a new settings was added in PSSA (this way it would not be breaking if someone used PSSA 1.19.0 with the current version of the extension). I could've applied something similar here and only added the new setting but for better naming, I decided to rename the setting powershell.codeFormatting.whitespaceAroundPipe to powershell.codeFormatting.trimWhitespaceAroundPipe, this is a breaking change, can we help the user point to the new setting? The new setting is powershell.codeFormatting.addWhitespaceAroundPipe and is disabled by default)
  • Add new setting powershell.codeFormatting.whitespaceBetweenParameters (disabled by default)
  • Add new None option for powershell.codeFormatting.pipelineIndentationStyle and make it the default. This new setting means that the formatter will not change the user's pipeline indentation so that the user has to explicitly opt-in, this was due community feedback.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister
Copy link
Contributor Author

cc @adamdriscoll

@bergmeister bergmeister marked this pull request as ready for review May 4, 2020 19:44
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt TylerLeonhardt merged commit 60e5648 into PowerShell:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants