Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Pending PSSA
1.19.0
release and this PSES PR, but I tested it locally: PowerShell/PowerShellEditorServices#1280powershell.codeFormatting.trimWhitespaceAroundPipe
setting into 2 settings since PSSA has changed the behaviour of the current setting to only add the missing white space around pipes but not remove any more. For trimming of redundant whitespace a new settings was added in PSSA (this way it would not be breaking if someone used PSSA 1.19.0 with the current version of the extension). I could've applied something similar here and only added the new setting but for better naming, I decided to rename the settingpowershell.codeFormatting.whitespaceAroundPipe
topowershell.codeFormatting.trimWhitespaceAroundPipe
, this is a breaking change, can we help the user point to the new setting? The new setting ispowershell.codeFormatting.addWhitespaceAroundPipe
and is disabled by default)powershell.codeFormatting.whitespaceBetweenParameters
(disabled by default)None
option forpowershell.codeFormatting.pipelineIndentationStyle
and make it the default. This new setting means that the formatter will not change the user's pipeline indentation so that the user has to explicitly opt-in, this was due community feedback.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets.Please mark anything not applicable to this PR
NA
.WIP:
to the beginning of the title and remove the prefix when the PR is ready