Skip to content

Register Language Server Client Proposed Features - Enabling Semantic Highlighting #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

justinytchen
Copy link
Contributor

Enabled proposed features for the language server client and enabled semantic highlighting in theme.json
See PowerShell/PowerShellEditorServices#1328 for more details

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests (NA)
  • This PR is ready to merge and is not work in progress

@justinytchen justinytchen changed the title Registered Proposed Features - Enabling Semantic Highlighting Register Language Server Client Proposed Features - Enabling Semantic Highlighting Jul 24, 2020
@TylerLeonhardt
Copy link
Member

@justinytchen what happens on vscode stable? If the extension fails to start, you may need to wrap that statement in a try/catch

@rjmholt rjmholt self-requested a review July 26, 2020 18:55
@TylerLeonhardt
Copy link
Member

This is stand alone (even though it's with the PSES PR) so I'm gonna merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants