Skip to content

Fixing installation behavior of brew for auto updater. Brew has deprecated cask use --cask instead. #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

philippkahr
Copy link
Contributor

@philippkahr philippkahr commented Jan 15, 2021

PR Summary

#3131 this issue is resolved by this PR.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests (didn't find any relevant test files for this case)
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@rjmholt rjmholt requested a review from andyleejordan February 2, 2021 21:24
@andyleejordan
Copy link
Member

I unfortunately don't yet have a MacOS device on which to test this, but after reviewing the brew manual, it looks correct. I have prior bad experience with how quickly the brew tool changes its CLI, with deprecations and removals happening within months. It is not a stable API by any means, and so scripting around it is nigh-impossible to keep correct. That said, this PR isn't adding that problem, it's simply dealing with its ramifications, so thank you for this contribution, I will merge it. I wish there were stable tooling for MacOS we could use instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants