Skip to content

Stop hiding Activity Bar in ISE Mode #4780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

andyleejordan
Copy link
Member

The user can, if they really wish, do this with
workbench.action.toggleActivityBarVisibility, but at least in the latest Insiders it does not appear we can set this to false any more. Moreover, it's a confusing UI change to make even for the sake of an "ISE-like" experience. Simplest answer seems to be to stop trying to hide it so as to unblock our CI.

The user can, if they really wish, do this with
`workbench.action.toggleActivityBarVisibility`, but at least in the
latest Insiders it does not appear we can set this to `false` any more.
Moreover, it's a confusing UI change to make even for the sake of an
"ISE-like" experience. Simplest answer seems to be to stop trying to
hide it so as to unblock our CI.
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit 8a626cd Oct 10, 2023
@andyleejordan andyleejordan deleted the andyleejordan/activity-bar branch October 10, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants