Merge pull request #61 from davidism/b902-mcs

allow 'mcs' for metaclass classmethod first arg

Author: cooperlees

Diff for: README.rst

@@ -233,6 +233,12 @@ MIT
 Change Log
 ----------
 
+19.3.0
+~~~~~~
+
+* For B902, the first argument for metaclass class methods can be
+  "mcs", matching the name preferred by PyCharm.
+
 18.2.0
 ~~~~~~
 

Diff for: bugbear.py

@@ -551,7 +551,7 @@ def visit(self, node):
 B902.implicit_classmethods = {"__new__", "__init_subclass__"}
 B902.self = ["self"]  # it's a list because the first is preferred
 B902.cls = ["cls", "klass"]  # ditto.
-B902.metacls = ["metacls", "metaclass", "typ"]  # ditto.
+B902.metacls = ["metacls", "metaclass", "typ", "mcs"]  # ditto.
 
 B903 = Error(
     message="B903 Data class should either be immutable or use __slots__ to "

Diff for: tests/b902.py

@@ -72,6 +72,10 @@ def __init__(self, name, bases, d):
     def __prepare__(cls, name, bases):
         return {}
 
+    @classmethod
+    def first_arg_mcs_allowed(mcs, value):
+        ...
+
 
 def type_factory():
     return object
@@ -85,3 +89,4 @@ def __init__(self):
 class RuntimeError("This is not a base"):
     def __init__(self):
         ...
+