allow 'mcs' for metaclass classmethod first arg #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out PyCharm's inspection allows choosing between "mcs" and "metacls", although it's not particularly discoverable. |
cooperlees
approved these changes
Mar 8, 2019
|
(I'll let this sit for a day or two incase anyone else has issues with this, if not, I'll merge and release to PyPI for you) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyCharm's inspector wants the first arg of metaclass class methods to be called "mcs", it will complain if it's called "metacls" or any of the names Bugbear currently allows. I'd like to be able to satisfy both PyCharm and Bugbear. Since there dosen't appear to be a source of truth for this list of allowed names, I felt it was OK to add this one.