Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B016: Warn when raising f-strings #341

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

FozzieHi
Copy link
Contributor

Warns when raising f-strings which I think matches the check's current description.

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Surprised this isn't a Python error, but neither are non f-strings so thanks for adding this! Wonder how many it will find around the world.

I wish we somehow had stats of all this plugin finds!

@cooperlees cooperlees merged commit a2e0c95 into PyCQA:main Jan 30, 2023
@FozzieHi FozzieHi deleted the b016-fstrings branch January 30, 2023 18:52
@jakkdl
Copy link
Contributor

jakkdl commented Jan 31, 2023

I wish we somehow had stats of all this plugin finds!

There's definitely ways of estimating those numbers, estimating the baseline prevalence of an error in projects without bugbear and multiplying by [estimated] number of flake8-bugbear installs. Or checking the number of hits on github search for the invalid pattern before and after implementing a new check. But that will underestimate the impact, as it only checks in pushed code and not thorny-bug-that-takes-much-longer-to-find-without-bugbear-but-will-get-fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants