Skip to content

Missing E133 test suite and E131 in E12 test suite #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TobiasRzepka opened this issue May 26, 2014 · 5 comments
Open

Missing E133 test suite and E131 in E12 test suite #293

TobiasRzepka opened this issue May 26, 2014 · 5 comments

Comments

@TobiasRzepka
Copy link

Hi, just to mention that for E133 there's no test in the test suite and the test for E131 is located in E12.py

@stchris
Copy link

stchris commented Jun 25, 2014

Not quite sure how to proceed with the E133 case, since it needs hang-closing. Trying to figure it out.

@florentx
Copy link
Contributor

actually, the E131 test is in the E12 file because it is the same category of errors (only the number has overflowed to the next range)
http://pep8.readthedocs.org/en/latest/intro.html#error-codes

For the E133 test, i haven't decided how to do it: either a standard unittest (see test_api.py), or write similar test as other codes and detect a new keyword "hang-closing", like I already detect "noeol" (see support.py).

@alecklandgraf
Copy link

I'm working on this one!

@alecklandgraf
Copy link

fixing this too:
image

alecklandgraf pushed a commit to alecklandgraf/pycodestyle that referenced this issue Jun 2, 2016
alecklandgraf pushed a commit to alecklandgraf/pycodestyle that referenced this issue Jun 2, 2016
@ashemedai
Copy link

Seems the commits by @alecklandgraf should be enough to close this issue, yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants