-
Notifications
You must be signed in to change notification settings - Fork 756
Update pep8 RTD to point to pycodestyle #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@IanLee1521 I am new to contributing to github projects. I read the contributing doc and am guessing I would first have to fork this project and then install virtualenv. Would it be possible for you to walk me through the process in resolving this issue please? |
Hi @JonathanDensil, thanks for your interest! For forking, I would take a look at the Forking Projects guide. For Virtualenv, I would take a look at their main documentation, specifically the Basic Usage section. Additionally, the CONTRIBUTING page has an example of walking through the whole process. |
Hi @IanLee1521 , I successfully forked the project and installed virtualenv, but I am using windows 10 and when I tried to run
I believe this is because 'source' is a linux command. Just running 'activate' does not give an error, but no result is shown either. How would I activate the virtual environment on windows 10? Interestingly (I'm not sure if this is right...): All of the paths have the same files in them, they look identical. That means that there is an activate and an activate.bat in each Scripts folder. I also don't have a bin folder (I suspect that bin is also only on linux) |
@JonathanDensil Did you read virtualenv's documentation on this? http://virtualenv.readthedocs.io/en/stable/userguide/#activate-script |
Ahh, I was using powershell and it required an execution policy. It works on the cmd. Thank you for your help. Now, onto resolving this issue. What would be the procedure be in doing so? |
Hi @JonathanDensil -- The typically workflow on GitHub, which we use, is:
GitHub has some decent guides on these topics : |
Hi @IanLee1521, well actually I was referring to this specific issue. I believe that you are referring to making a link for the words under the note section: pep8 to https://www.python.org/dev/peps/pep-0008/; and pycodestyle to https://pypi.python.org/pypi/pep8/1.7.0. If this is the case, I couldn't find the file to edit and add those links in the code base. The intro.rst file under docs doesn't include the note so I couldn't edit that section. Where would I be able to find that section? |
I want to encourage you to poke around a bit on your own before just giving everything away, but the gotcha there is a bit odd. That link is to the |
Ohh I see. I have downloaded the GitHub for Windows and have forked the repository. I have been doing some messing around with a small repository that I made for myself. Not to be hasty or anything, I am just really excited to have my first contribution to a public open source project, just so that I can get the ball rolling and contribute more. So, if I add the link to the index.rst in my forked repository and then commit and push it to the |
Hi @IanLee1521, I edited the index.rst document, committed the changes to my fork and then created a pull request back to the original repository. It says that all checks have failed, but I presume that it was because index.rst is not a python file. Please review my pull request. |
Hi @sigmavirus24 and @IanLee1521, I corrected the problem with the previous commit, changed the link addresses and abided by the line length guide as requested by sigmavirus24 in his review of my previous commit. I hope that I have done it right this time. Thank you, please review. |
This will render for users who look at pep8 1.7.x's documentation and hopefully help inform them that pep8 is deprecated and now replaced by pycodestyle. Closes #602
I think this issue can now be closed; #606 has been merged which added this to https://pep8.readthedocs.io/en/release-1.7.x/: |
From #466 (comment)
The text was updated successfully, but these errors were encountered: