Refactor: remove the 'total_lines' variable from the 'trailing_blank_lines' check

[jayaddison]

May resolve #1142.

[pablogsal]

Give us one week or so because we may change this upstream (although I want to reiterate that we don't really need to).

[jayaddison]

Any interest in this as a cleanup despite the upstream fix, @asottile? (I'm guessing not, and will likely delete the branch/fork soon, but figured it'd be worth checking)

[asottile]

it has a correctness issue so probably not

(with blank line at end)

print(1)


print(2)


print(3)

$ python3 -m pycodestyle t.py
t.py:1:1: W391 blank line at end of file
t.py:2:1: W391 blank line at end of file
t.py:3:1: W391 blank line at end of file
t.py:4:1: W391 blank line at end of file
t.py:5:1: W391 blank line at end of file
t.py:6:1: W391 blank line at end of file
t.py:7:1: W391 blank line at end of file
t.py:8:1: W391 blank line at end of file

[jayaddison]

Hehe, ok - yep, that definitely settles it. Thank you.

[jayaddison]

(I did test it in combination with flake8-pyi, but evidently missed whatever issue that is. I might take another look, probably not though)

[jayaddison]

It's because it runs once per-line, of course. Never mind, ignore me. I seem to be getting worse and worse at computers.