fix some wrong renames from testsuite to testing/data vs test #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Jul 21, 2023
tests/test_shell.py
Outdated
| @@ -194,7 +194,7 @@ def test_check_diff(self): | |||
| )) | |||
|
|
|||
| # no matching file in the diff | |||
| diff_lines[3] = "+++ b/testing/lost/E11.py" | |||
There was a problem hiding this comment.
this one is correct -- it's meant to be a replacement for testing/data/E11.py but "list"
There was a problem hiding this comment.
well in this diff from #1175 you can see it was lost even before your change...
should I still change it to be list instead of lost -- or did I misunderstand your comment?
There was a problem hiding this comment.
phone typo -- it's supposed to be lost
There was a problem hiding this comment.
oh okay. also yes I see what you mean about testing, will remove this part :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these changes were initially made in #1175 and I noticed some were made incorrectly (tests instead of testing/data and vice versa)
the second change (with
lost/E11.py) doesn't really exist in either tests or testing but thought it would be better for it to be tests/lost instead