Skip to content

Fix problem with treating ~ operator as binary. #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2016

Conversation

czyzykowski
Copy link
Contributor

Fixes #384

@mbarrien
Copy link

Ping on getting this merged? Affecting my projects.

@Incognito
Copy link

Any chance this can get merged? @IanLee1521 @Nurdok @PCManticore @sigmavirus24 (@-ing people public on the PyCQA org).

@sigmavirus24
Copy link
Member

@Incognito the only people who are allowed to merge pull requests here are @IanLee1521 and myself. Please don't try to @-mention the entire organization.

As for this pull request, the original issue has people claiming this is an incomplete fix. If you want to make sure this is fixed, could you verify that concern? If this works for your case and the other cases described there, I'll be happy to merge it if @IanLee1521 can't get around to it.

@sigmavirus24
Copy link
Member

IMO, the person saying this didn't fix the case with - seems to be incorrect. The docstring tests clearly test that case so I think that case is already covered. This also looks to fix the original bug. I'll try to test this tonight.

IanLee1521 added a commit that referenced this pull request Feb 24, 2016
Fix problem with treating ~ operator as binary.
@IanLee1521 IanLee1521 merged commit 4fb305e into PyCQA:master Feb 24, 2016
@IanLee1521
Copy link
Member

So I looked at it, and it there is a warning if you add a doctest of Okay: var = (1 &\n -2) or Okay: var = (1 *\n -2), the W503 warning does pop up. I'm going to open a separate issue for that, and merge / close this one which is specific to the ~ operator. #484

@Incognito
Copy link

Thanks for getting this through! I appreciate having this fix.

pointlessone added a commit to pointlessone/pep8 that referenced this pull request Dec 29, 2016
2.2.0 (2016-11-14)
------------------

Bugs:

* Fixed E305 regression caused by PyCQA#400;
  PyCQA#593

2.1.0 (2016-11-04)
------------------

Changes:

* Report E302 for blank lines before an "async def";
  PyCQA#556
* Update our list of tested and supported Python versions which are 2.6,
  2.7, 3.2, 3.3, 3.4 and 3.5 as well as the nightly Python build and
  PyPy.
* Report E742 and E743 for functions and classes badly named 'l', 'O',
  or 'I'.
* Report E741 on 'global' and 'nonlocal' statements, as well as
  prohibited single-letter variables.
* Deprecated use of `[pep8]` section name in favor of `[pycodestyle]`;
  PyCQA#591

Bugs:

* Fix opt_type AssertionError when using Flake8 2.6.2 and pycodestyle;
  PyCQA#561
* Require two blank lines after toplevel def, class;
  PyCQA#536
* Remove accidentally quadratic computation based on the number of
  colons. This will make pycodestyle faster in some cases;
  PyCQA#314

2.0.0 (2016-05-31)
------------------

Changes:

* Added tox test support for Python 3.5 and pypy3
* Added check E275 for whitespace on `from ... import ...` lines;
  PyCQA#489 / PyCQA#491
* Added W503 to the list of codes ignored by default ignore list;
  PyCQA#498
* Removed use of project level `.pep8` configuration file;
  PyCQA#364

Bugs:

* Fixed bug with treating `~` operator as binary; PyCQA#383
  / PyCQA#384
* Identify binary operators as unary; PyCQA#484 /
  PyCQA#485

1.7.0 (2016-01-12)
------------------

Changes:

* Reverted the fix in PyCQA#368, "options passed on command
  line are only ones accepted" feature. This has many unintended
  consequences in pep8 and flake8 and needs to be reworked when I have
  more time.
* Added support for Python 3.5. (Issue PyCQA#420 &
  PyCQA#459)
* Added support for multi-line config_file option parsing. (Issue
  PyCQA#429)
* Improved parameter parsing. (Issues PyCQA#420 &
  PyCQA#456)

Bugs:

* Fixed BytesWarning on Python 3. (Issue PyCQA#459)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tilde is treated as binary operator
5 participants