Switch Travis to use tox #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmavirus24
force-pushed
the
use-tox-with-travis
branch
2 times, most recently
from
be00648 to
287da10
Compare
| deps = | ||
| flake8 | ||
| commands = | ||
| flake8 pycodestyle.py |
There was a problem hiding this comment.
What's the rationale behind running flake8 on pycodestyle? Not specifically disagreeing, just seems to not be part of the "Switch Travis to use tox" issue.
There was a problem hiding this comment.
Flake8, as I'm sure you know, includes pyflakes. When I was writing some of the more recent pull requests, I found several pyflakes lint problems (which I also submitted separate pull requests for). If pycodestyle runs flake8 on all submitted changes, then those shouldn't pop up again.
It's something of an extra check to ensure the quality of pycodestyle doesn't dip.
sigmavirus24
force-pushed
the
use-tox-with-travis
branch
6 times, most recently
from
0eba374 to
e0106dd
Compare
This reduces confusion about how travis runs tests versus a local developer. Unfortunately, pypy3 on Travis is stuck to a version that only implements Python 3.2. There is no convenient work around for that version so we remove it from our matrix until Travis updates their images.
sigmavirus24
force-pushed
the
use-tox-with-travis
branch
from
e0106dd to
5a14978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces confusion about how travis runs tests versus a local
developer.
Note this also adds a Flake8 test env and runs it at the gate to catch other instances of #540