This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Print errors to stdout #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2016
Closed
varunagrawal
changed the title
varunagrawal
changed the title
Closed
Nurdok
suggested changes
Oct 13, 2016
| @@ -53,7 +53,7 @@ def run_pydocstyle(use_pep257=False): | |||
|
|
|||
| count = 0 | |||
| for error in errors: | |||
| sys.stderr.write('%s\n' % error) | |||
| sys.stdout.write('%s\n' % error) | |||
There was a problem hiding this comment.
Now that errors are prints to stdout, notice that the test for --count in test_integration.py needs to be made more robust.
There was a problem hiding this comment.
How would you suggest I go about doing this?
There was a problem hiding this comment.
Instead of checking that the count number is somewhere in the output, check that it's the last line of stdout.
Nurdok
suggested changes
Oct 23, 2016
| @@ -53,7 +53,7 @@ def run_pydocstyle(use_pep257=False): | |||
|
|
|||
| count = 0 | |||
| for error in errors: | |||
| sys.stderr.write('%s\n' % error) | |||
| sys.stdout.write('%s\n' % error) | |||
There was a problem hiding this comment.
Instead of checking that the count number is somewhere in the output, check that it's the last line of stdout.
Nurdok
approved these changes
Oct 25, 2016
|
Merged. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #201