Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Add support for python 3.7 #324

Merged
merged 2 commits into from
Jul 15, 2018
Merged

Add support for python 3.7 #324

merged 2 commits into from
Jul 15, 2018

Conversation

michael-k
Copy link
Contributor

No description provided.

.travis.yml Outdated
@@ -17,6 +17,8 @@ matrix:
env: TOXENV=py35-tests
- python: 3.6
env: TOXENV=py36-tests
- python: 3.7-dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.7-dev is ancient compared to 3.7. There are other ways to get the real python 3.7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is, but I don't like the work arounds mentioned in the ticket. I hope that the travis-ci folks will fix this soon.

@Nurdok
Copy link
Member

Nurdok commented Jul 15, 2018

This change looks fine except for the issue with Travis-CI. I rather wait for them to support the official 3.7 release instead of using the old development branch. So I'm not merging this for now, hopefully it will be resolved soon.

@Nurdok
Copy link
Member

Nurdok commented Jul 15, 2018

@michael-k thanks for taking the time to do this and sorry for the delay.

@sigmavirus24
Copy link
Member

If you use the xenial image you can get python3.7 for real

@michael-k michael-k force-pushed the python3.7 branch 2 times, most recently from 3320fe4 to cfdbe61 Compare July 15, 2018 14:33
Importing abstract base classes from collections is deprecated since
Python 3.7, see https://bugs.python.org/issue25988.
@michael-k
Copy link
Contributor Author

I've added dist: xenial for the 3.7 test runs. But for it to work, I've also had to add sudo: required. See eg. travis-ci/travis-ci#9815 (comment) and the three comments before that one.

@Nurdok Nurdok merged commit 7f5303c into PyCQA:master Jul 15, 2018
@michael-k michael-k deleted the python3.7 branch July 15, 2018 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants