Skip to content

2.2.0 #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

2.2.0 #524

wants to merge 1 commit into from

Conversation

asottile
Copy link
Member

No description provided.

@asottile
Copy link
Member Author

(I don't have pypi permission, I believe if this looks good @bitglue or @florentx would need to promote this)

@asottile
Copy link
Member Author

#523 is needed for CI to be green

@yeliudev
Copy link

Hi @asottile ! Thanks for the great work. May I ask that will the latest commit "Fix pyflakes for removal of ast.Param" also be included in the 2.2.0a1 version? It seems that ast.Param is used in Python nightly in Linux as well.

@asottile
Copy link
Member Author

@C1ariS it is, however it doesn't matter as they are reverting in cpython: python/cpython#19056

@yeliudev
Copy link

Okay, thank you so much!

@bitglue
Copy link
Member

bitglue commented Apr 8, 2020

Let's just make it 2.2.0? There's always 2.2.1, if something needs fixing.

@asottile
Copy link
Member Author

asottile commented Apr 8, 2020

sure, I figure an alpha release is probably better so there can be some soft vetting, but it's your project so I'm happy do what you want, I'll go drop the "a1"

@asottile asottile changed the title 2.2.0a1 2.2.0 Apr 8, 2020
@bitglue
Copy link
Member

bitglue commented Apr 10, 2020

Thanks for putting this together @asottile. And apologies to everyone else for the delay. I'm going to add some additional maintainers to pypi to busproof this process.

I had to tweak the version number in __init__.py so I amended the commit and merged c72d6cf.

@bitglue bitglue closed this Apr 10, 2020
@bitglue
Copy link
Member

bitglue commented Apr 10, 2020

Heh, I probably should have tweaked the release date in news.rst, too :(

The most tedious part of making these releases is updating that silly file. Would too many people be upset if we just deleted it? There's always the git history. Or perhaps there's some way to automatically generate it? Or we just require PRs to update it? Open to ideas.

@asottile asottile deleted the 2_2_0_a1 branch April 10, 2020 04:07
@asottile
Copy link
Member Author

oops, I knew I forgot something 🤦

the changelog is a bit tedious but I'm happy to fill it out when making releases 🤷 I think it's still somewhat valuable for large/popular projects such as pyflakes as traversing the git history on github is not always the easiest. having contributors edit it often ends up in merge conflict messes unless you do something like towncrier to manage changelog fragments (and then merge them all together at the end) -- but then you end up being in the business of policing those which can be quite some work -- I guess worst case we continue what we're doing and I'm fine maintaining that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants