Skip to content

Allow useless conversion #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Allow useless conversion #4838

merged 1 commit into from
Jan 8, 2025

Conversation

mejrs
Copy link
Member

@mejrs mejrs commented Jan 6, 2025

Fixes #4828

@mejrs mejrs added the CI-skip-changelog Skip checking changelog entry label Jan 6, 2025
@ngoldbaum ngoldbaum added this pull request to the merge queue Jan 8, 2025
@ngoldbaum
Copy link
Contributor

This fixes the spurious warnings when I build bcrypt on nightly, thanks!

Merged via the queue into PyO3:main with commit 4670203 Jan 8, 2025
47 checks passed
davidhewitt pushed a commit that referenced this pull request Jan 10, 2025
davidhewitt pushed a commit that referenced this pull request Jan 11, 2025
JeanArhancet pushed a commit to JeanArhancet/pyo3 that referenced this pull request Jan 17, 2025
amorenoz added a commit to amorenoz/retis that referenced this pull request Feb 28, 2025
Clippy is warning about an useless conversion that happens inside
pyo3. This got fixed in 0.23.5:

PyO3/pyo3#4838

Signed-off-by: Adrian Moreno <[email protected]>
robamler added a commit to bamler-lab/constriction that referenced this pull request Mar 5, 2025
weiji14 added a commit to weiji14/cog3pio that referenced this pull request Mar 17, 2025
weiji14 added a commit to weiji14/cog3pio that referenced this pull request Mar 18, 2025
* 🎨 Lint GitHub Actions workflow YAML files

Consistent whitespace, and double quotes instead of single quotes.

* 👷 Run CI on ubuntu-24.04, macos-15, windows-2025

Upgrade to latest runners listed at https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

* ⬆️ Bump CodSpeedHQ/action from 2.2.1 to 3.5.0

Bumps [CodSpeedHQ/action](https://github.com/codspeedhq/action) from 2.2.1 to 3.5.0.
- [Release notes](https://github.com/codspeedhq/action/releases)
- [Changelog](https://github.com/CodSpeedHQ/action/blob/main/CHANGELOG.md)
- [Commits](CodSpeedHQ/action@v2.2.1...v3.5.0)

Upgrading to support ubuntu-24.04 runner.

* ⬆️ Bump uraimo/run-on-arch-action from 2.8.1 to 3.0.0

Bumps [uraimo/run-on-arch-action](https://github.com/uraimo/run-on-arch-action) from 2.8.1 to 3.0.0.
- [Release notes](https://github.com/uraimo/run-on-arch-action/releases)
- [Commits](uraimo/run-on-arch-action@v2.8.1...v3.0.0)

See if it fixes ppc64le build errors.

* ⬆️ Bump pyo3 from 0.23.2 to 0.23.4

Bumps [pyo3](https://github.com/pyo3/pyo3) from 0.23.2 to 0.23.4.
- [Release notes](https://github.com/pyo3/pyo3/releases)
- [Changelog](https://github.com/PyO3/pyo3/blob/main/CHANGELOG.md)
- [Commits](PyO3/pyo3@v0.23.2...v0.23.4)

Contains patch from PyO3/pyo3#4838 to fix PyO3/pyo3#4828 `useless_conversion` clippy lint
atenart pushed a commit to retis-org/retis that referenced this pull request Mar 21, 2025
Clippy is warning about an useless conversion that happens inside
pyo3. This got fixed in 0.23.5:

PyO3/pyo3#4838

Signed-off-by: Adrian Moreno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"useless_conversion" with #[pyfunction] returning PyResult<_> on nightly
2 participants