Add display cell tokenizer #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #663 Add a new function `display_cell_tokenize` to split Thai text into display cells without splitting tone marks. * **New Functionality** - Add `display_cell_tokenize` function in `pythainlp/tokenize/core.py` to handle the splitting of Thai text into display cells. - Ensure the function does not split tone marks. * **Initialization** - Update `pythainlp/tokenize/__init__.py` to include the new `display_cell_tokenize` function in the `__all__` list. * **Testing** - Add tests for the `display_cell_tokenize` function in `tests/core/test_tokenize.py`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/PyThaiNLP/pythainlp/issues/663?shareId=XXXX-XXXX-XXXX-XXXX).
|
Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2025-01-08 13:42:07 UTC |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #663
Add a new function
display_cell_tokenizeto split Thai text into display cells without splitting tone marks.display_cell_tokenizefunction inpythainlp/tokenize/core.pyto handle the splitting of Thai text into display cells.pythainlp/tokenize/__init__.pyto include the newdisplay_cell_tokenizefunction in the__all__list.display_cell_tokenizefunction intests/core/test_tokenize.py.For more details, open the Copilot Workspace session.