Skip to content

Manage extra requires + merge g2p and romanization to one transliterate module #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 9, 2018
Merged

Manage extra requires + merge g2p and romanization to one transliterate module #153

merged 14 commits into from
Nov 9, 2018

Conversation

bact
Copy link
Member

@bact bact commented Nov 6, 2018 •
edited
Loading

@coveralls
Copy link

coveralls commented Nov 6, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-21.5%) to 72.219% when pulling a47d297 on bact:dev into 580ea00 on PyThaiNLP:dev.

@bact
Copy link
Member Author

bact commented Nov 8, 2018 •
edited
Loading

Build fails, basically from missing imports (epitrain).

Another issue related to imports. Have to decided how to deal with "optional packages" that used by some functionalities.

@bact bact mentioned this pull request Nov 8, 2018
Closed
@bact
Copy link
Member Author

bact commented Nov 9, 2018 •
edited
Loading

Travis fails because: The job exceeded the maximum log length, and has been terminated. Too many packages to install.

AppVeyor fails because there's no torch PyPI package for Windows.

@bact
Copy link
Member Author

bact commented Nov 9, 2018

Test on Windows (AppVeyor) fails due to UnicodeDecodeError in artagger (#155)

@bact bact changed the title Propose to merge g2p and romanization modules to one common transliterate module Manage extra requires + merge g2p and romanization to one transliterate module Nov 9, 2018
@bact bact requested a review from wannaphong November 9, 2018 04:58
wannaphong
wannaphong reviewed Nov 9, 2018
View reviewed changes
@bact bact merged commit 694dbf7 into PyThaiNLP:dev Nov 9, 2018
@wannaphong wannaphong mentioned this pull request Nov 9, 2018
Closed
@wannaphong wannaphong added this to the 1.8 milestone Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wannaphong wannaphong wannaphong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @coveralls @wannaphong