Skip to content

Fix %O modifier for thai_strftime() #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2020
Merged

Fix %O modifier for thai_strftime() #441

merged 4 commits into from
Jun 26, 2020

Conversation

bact
Copy link
Member

@bact bact commented Jun 25, 2020 •
edited
Loading

This should close #436

(thai_strftime: %O modifier failed to convert year to Thai digit)

@pep8speaks
Copy link

pep8speaks commented Jun 25, 2020 •
edited
Loading

Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-26 09:10:34 UTC

@coveralls
Copy link

coveralls commented Jun 25, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 95.436% when pulling bc382ab on fix-thai_strftime into 7f24af2 on dev.

@bact bact merged commit 6c83fd5 into dev Jun 26, 2020
@wannaphong wannaphong mentioned this pull request Jun 27, 2020
Merged
@bact bact deleted the fix-thai_strftime branch June 27, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wannaphong wannaphong wannaphong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thai_strftime: %O modifier failed to convert year to Thai digit
4 participants
@bact @pep8speaks @coveralls @wannaphong