Skip to content

edited engine name and add phayathai pos_tag model to transformer_tag #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

MpolaarbearM
Copy link
Contributor

What does this changes

Add model lunarlist/pos_thai_phayathai to the pos tag transformer and fix some engine names being too long

What was wrong


How this fixes it


Fixes #...

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Nov 30, 2023

Hello @MpolaarbearM! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-30 11:25:44 UTC

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bact
Copy link
Member

bact commented Nov 30, 2023

Tag @pavaris-pm as they just made related changes in #865 and may have few comments.

@bact bact added the enhancement enhance functionalities label Nov 30, 2023
@bact bact added this to the Future milestone Nov 30, 2023
@pavaris-pm
Copy link
Contributor

pavaris-pm commented Dec 1, 2023

@MpolaarbearM I'm not sure about this. Did you sync the change from the upstream repo to your forked version repo before made this PR? since I've a discussion about model name / code refactoring with @bact and made change by adding dictionary lookup in PR #865, but seems like the change you've made in this PR did not match with the previous version that I do code refactorization krub.

@pavaris-pm
Copy link
Contributor

pavaris-pm commented Dec 1, 2023

@MpolaarbearM I'm not sure about this. Did you sync the change from the upstream repo to your forked version repo before made this PR? since I've a discussion about model name / code refactoring with @bact and made change by adding dictionary lookup in PR #865, but seems like the change you've made in this PR did not match with the previous version that I do code refactorization krub.

@MpolaarbearM i already fix it already by sync the change in new PR #873 . You can now close this PR after saw this comment krub.

However, big thanks for your effort for training the pos tagging model on blackboard corpus. I promise that i will not forget to make a co-authored commit to give you a credit for it as well. According to that, can you give me an email that you currently use with your github ?, so that i can make a co-authored commit for you krub. if you do not want to show your email here, you can send it via my email as shown in my github profile krub.

@MpolaarbearM
Copy link
Contributor Author

@pavaris-pm thank you very much krub!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhance functionalities
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

4 participants