Skip to content

Remove unused pytest #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2024
Merged

Remove unused pytest #950

merged 3 commits into from
Oct 31, 2024

Conversation

bact
Copy link
Member

@bact bact commented Oct 31, 2024 •
edited
Loading

  • Also remove nltk.download, as it is no longer necessary. The wordnet module already check if omw exist

@bact bact added the infrastructure build process, configuration, GitHub Actions label Oct 31, 2024
bact added 2 commits October 31, 2024 15:01
@bact
Remove nltk.download
60eac13 
Not necessary anymore. The wordnet package already check it
@bact
Use all pips, no conda; add cache
41f914a
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bact bact merged commit 4debf60 into PyThaiNLP:dev Oct 31, 2024
11 checks passed
@bact bact deleted the rm-wordnet-in-setuppy branch October 31, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
infrastructure build process, configuration, GitHub Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bact