Skip to content

Specify a limited test suite #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Nov 1, 2024
Merged

Specify a limited test suite #952

merged 46 commits into from
Nov 1, 2024

Conversation

bact
Copy link
Member

@bact bact commented Oct 31, 2024

Define load_tests() in tests/init.py

Will fix #931

@coveralls
Copy link

coveralls commented Oct 31, 2024

Coverage Status

coverage: 32.613% (+32.6%) from 0.0%
when pulling 331eb2b on bact:add-test-suites
into 89ea62e on PyThaiNLP:dev.

Copy link

sonarqubecloud bot commented Nov 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@bact
Copy link
Member Author

bact commented Nov 1, 2024

Test is now able to run on 3.9 to 3.13, install PyICU on Windows and install PyTorch on every platform.

Some tests that require external imports are not in tests/testx_.py (instead of test_.py), to make it able to run some tests without those imports (and facing import conflicts)

@bact
Copy link
Member Author

bact commented Nov 1, 2024

Will merge for now, the test_sent_tokenize and test_normalize that failed have to be fix in another PR

@bact bact merged commit 4033085 into PyThaiNLP:dev Nov 1, 2024
5 of 22 checks passed
@bact bact deleted the add-test-suites branch November 1, 2024 09:45
@bact bact added the tests Unit test, code coverage, test case label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Unit test, code coverage, test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test CI breaks
2 participants