Use "build" instead of setup.py + add "[cd build]" build trigger word #994

bact · 2024-11-13T15:44:49Z

python setup.py and the use of setup.py as a command line tool are deprecated.

This PR replace python setup.py sdist bdist_wheel with python -m build, as recommended in https://packaging.python.org/en/latest/discussions/setup-py-deprecated/

Also remove setuptools and wheel dependencies
Also add a wheel build trigger. If want to test the build process, just add "[cd build]" to the commit message

setup.py is now discourage. Also remove setuptools and wheel dependencies

coveralls · 2024-11-13T15:51:11Z

coverage: 52.154% (+0.05%) from 52.102%
when pulling f3190e1 on bact:build-using-cibuildwheel
into 3b26823 on PyThaiNLP:dev.

sonarqubecloud · 2024-11-13T16:58:22Z

Quality Gate passed

bact · 2024-11-13T17:06:54Z

Will merge. Trigger works.

The failed test is from the time out of ConceptNet connection.

Use "build" instead of setup.py

ff6287f

setup.py is now discourage. Also remove setuptools and wheel dependencies

bact added the infrastructure build process, configuration, GitHub Actions label Nov 13, 2024

bact added 3 commits November 13, 2024 16:39

Test build [cd build]

238ec2b

Change branch name [cd build]

5eff809

Add check build trigger [cd build]

f3190e1

bact changed the title ~~Use "build" instead of setup.py~~ Use "build" instead of setup.py + add "[cd build]" build trigger word Nov 13, 2024

bact merged commit 630b355 into PyThaiNLP:dev Nov 13, 2024
26 of 28 checks passed

bact deleted the build-using-cibuildwheel branch November 13, 2024 17:07