Skip to content

Fix Unicode headers in emails #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jpmelos
Copy link
Contributor

@jpmelos jpmelos commented Jan 10, 2020

Fixes #534.

Client code that generates the headers is usually using the future definitions of things like strings already, which means that the future code itself should expect those things in its own code as well, like comparing to builtins.str instead of just the native str.

@jmadler jmadler merged commit fcd78df into PythonCharmers:master Feb 5, 2020
@jmadler
Copy link
Contributor

jmadler commented Feb 5, 2020

Fantastic work! Thanks for contributing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport of email package breaks when used with unicode newstr
2 participants