Skip to content

fix: Migrating tables #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2021
Merged

fix: Migrating tables #342

merged 2 commits into from
Oct 15, 2021

Conversation

orronai
Copy link
Collaborator

@orronai orronai commented Oct 15, 2021

  • Added exception of exercise - course and number indexes migration

- Added exception of exercise - course and number indexes migration
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #342 (8005b23) into master (2c71ba3) will increase coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 8005b23 differs from pull request most recent head 91fe85f. Consider uploading reports for the commit 91fe85f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   83.96%   84.02%   +0.05%     
==========================================
  Files          63       63              
  Lines        2950     2948       -2     
==========================================
  Hits         2477     2477              
+ Misses        473      471       -2     
Impacted Files Coverage Δ
lms/lmsdb/bootstrap.py 15.65% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c71ba3...91fe85f. Read the comment docs.

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 15, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.52%.

Quality metrics Before After Change
Complexity 2.23 ⭐ 1.96 ⭐ -0.27 👍
Method Length 48.33 ⭐ 47.96 ⭐ -0.37 👍
Working memory 6.65 🙂 6.57 🙂 -0.08 👍
Quality 79.25% 79.77% 0.52% 👍
Other metrics Before After Change
Lines 312 306 -6
Changed files Quality Before Quality After Quality Change
lms/lmsdb/bootstrap.py 79.25% ⭐ 79.77% ⭐ 0.52% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
lms/lmsdb/bootstrap.py _migrate_column_in_table_if_needed 6 ⭐ 116 🙂 11 😞 59.05% 🙂 Extract out complex expressions
lms/lmsdb/bootstrap.py _rename_column_in_table_if_needed 2 ⭐ 104 🙂 10 😞 66.46% 🙂 Extract out complex expressions
lms/lmsdb/bootstrap.py main 7 ⭐ 136 😞 6 ⭐ 66.65% 🙂 Try splitting into smaller methods
lms/lmsdb/bootstrap.py _alter_column_type_if_needed 1 ⭐ 93 🙂 10 😞 68.98% 🙂 Extract out complex expressions
lms/lmsdb/bootstrap.py _migrate_copy_column 0 ⭐ 62 🙂 10 😞 74.59% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@orronai orronai merged commit 6f13160 into master Oct 15, 2021
@orronai orronai deleted the fix-migrating-tables branch October 15, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants