WIP: port numpy testing #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-br
force-pushed
the
np_testing
branch
3 times, most recently
from
a554609 to
989229d
Compare
numpy commit 1d5b3397dc7beaf9ca7b2326127e74f55aecd162 (numpy main branch, Dec 2022)
- remove clearly outdated stuff (KnownFailureException, import_nose, datetime support etc) - fix up imports from numpy to torch_np --- in *some* functions. ATM, things which are exposed in `torch_np.testing` via `__init__.py` are OK, the rest isn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to bring in numpy tests of dtypes to finish up gh-12, but of course these tests use all sorts of things from
numpy.testing. So let's port it first.The current status:
np.bool_(value)etc. So no clean separation of concerns, no small PRs just yet, sadly.isscalarfunction, cf https://numpy.org/doc/stable/reference/generated/numpy.isscalar.htmltestingmodule has nice habit of importing stuff from numpy within functions, so anything not exercised by tests is broken. At some point we'll need a CI run without numpy.