Add a layer to a viewer with drag and drop #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
for more information, see https://pre-commit.ci
brichet
commented
Jul 6, 2023
| } | ||
|
|
||
| export interface IChange { | ||
| action: 'close' | 'lock' | 'edit'; | ||
| action: 'close' | 'lock' | 'edit' | 'layer'; | ||
| dataLayer?: string; |
There was a problem hiding this comment.
I'm not really satisfied by this but this was the easiest way to manage the change.
We could find something more generic since other futur changes may require arguments.
trungleduc
approved these changes
Jul 7, 2023
|
Thanks @brichet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is:
sessionWidget)changesignal totabLayout, which execute the command in the kernel.EDIT:
Some ui-tests failed for snapshot error not related to this PR, so I added
--retries=3when running the playwright tests.