[CK_TILE] Move GEMM pipeline tail handling logic to pipelines #2222
+234
−553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samremes
requested review from
illsilin,
carlushuang,
qianfengz,
aosewski,
poyenc,
geyyer,
bartekxk,
andriy-ca,
afagaj,
asleepzzz,
tenpercent,
ThomasNing and
coderfeli
as code owners
aosewski
requested changes
May 28, 2025
|
|
||
| template <typename RunFunction> | ||
| CK_TILE_HOST_DEVICE static auto | ||
| TailHandler(RunFunction run_func, bool has_hot_loop, TailNumber tail_number) |
There was a problem hiding this comment.
Suggested change
| TailHandler(RunFunction run_func, bool has_hot_loop, TailNumber tail_number) | |
| TailHandler(const RunFunction& run_func, bool has_hot_loop, TailNumber tail_number) |
| } | ||
| } | ||
| #if defined(__HIP_DEVICE_COMPILE__) | ||
| // This path should be unreachable in device code if tail_number is always valid. |
There was a problem hiding this comment.
Suggested change
| // This path should be unreachable in device code if tail_number is always valid. | |
| // This path should be unreachable in device code if tail_number is valid. |
|
|
||
| template <typename RunFunction> | ||
| CK_TILE_HOST_DEVICE static auto | ||
| TailHandler(RunFunction run_func, bool has_hot_loop, TailNumber tail_number) |
There was a problem hiding this comment.
Suggested change
| TailHandler(RunFunction run_func, bool has_hot_loop, TailNumber tail_number) | |
| TailHandler(const RunFunction& run_func, bool has_hot_loop, TailNumber tail_number) |
| } | ||
|
|
||
| auto check_tail = [&](auto... TNs) { | ||
| (try_run<BaseGemmPipeline, decltype(TNs)::value>(tail_num), ...); |
There was a problem hiding this comment.
Please remove the unused try_run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In this PR, the GEMM pipeline tail handling logic is moved to a function inside the pipeline itself, so that the user code (e.g. the example and tests) doesn't have to do it for each pipeline that can be used. Also the persistent variant of the grouped gemm kernel needs to do tail handling logic in device code, now that is also implemented within the pipeline code itself.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered