Skip to content

[release/2.5][ROCm][TunableOp] Improve identification of fastest solution (#144942) #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

naromero77amd
Copy link

This PR addresses some stability issues with identifying the fastest solution on AMD GPUs, particularly the MI300.

Changes include:

  • An improved timer, StreamTimerNoSync
  • More aggressive skipping of slow solutions
  • Additional statistics that can be used for diagnostics PYTORCH_TUNABLEOP_VERBOSE=3

Pull Request resolved: pytorch#144942
Approved by: https://github.com/jeffdaily

(cherry picked from commit fd0cd6a)

…#144942)

This PR addresses some stability issues with identifying the fastest solution on AMD GPUs, particularly the MI300.

Changes include:
- An improved timer, StreamTimerNoSync
- More aggressive skipping of slow solutions
- Additional statistics that can be used for diagnostics PYTORCH_TUNABLEOP_VERBOSE=3

Pull Request resolved: pytorch#144942
Approved by: https://github.com/jeffdaily

(cherry picked from commit fd0cd6a)
@naromero77amd
Copy link
Author

This is a performance improvement from upstream. So far, there have been no negative reports w.r.t. to performance. So, I think it's worth backporting. I will also add it to ROCm release/2.6. It cannot be trivially backported to release/2.4.

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 4, 2025

Jenkins build for acd66a22a6f79aa784015121cc22fa653ac1e9bb commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 10, 2025

Jenkins build for acd66a22a6f79aa784015121cc22fa653ac1e9bb commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 10, 2025

Jenkins build for acd66a22a6f79aa784015121cc22fa653ac1e9bb commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 16, 2025

Jenkins build for acd66a22a6f79aa784015121cc22fa653ac1e9bb commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

Jenkins build for acd66a22a6f79aa784015121cc22fa653ac1e9bb commit is in progress
Links: Blue Ocean view / Build artifacts

@pruthvistony pruthvistony merged commit 554c7b1 into release/2.5 Apr 21, 2025
2 of 7 checks passed
@pruthvistony pruthvistony deleted the release/2.5_rocm_tunableop_improved_criteria branch April 21, 2025 22:36
@naromero77amd naromero77amd restored the release/2.5_rocm_tunableop_improved_criteria branch April 21, 2025 22:47
@naromero77amd
Copy link
Author

!cherry-pick --onto release/2.6

rocm-mici pushed a commit that referenced this pull request Apr 21, 2025
…tion (pytorch#144942) (#2018)

This PR addresses some stability issues with identifying the fastest
solution on AMD GPUs, particularly the MI300.

Changes include:
- An improved timer, StreamTimerNoSync
- More aggressive skipping of slow solutions
- Additional statistics that can be used for diagnostics
PYTORCH_TUNABLEOP_VERBOSE=3

Pull Request resolved: pytorch#144942
Approved by: https://github.com/jeffdaily

(cherry picked from commit fd0cd6a)
@rocm-mici
Copy link

Created branch autogenerated/release/2.6_cherry-pick_pr-2018 and #2041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants