-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[RFC][doxygen]Doxygen comment standard processing #10058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
891a80d
to
7368f5f
Compare
ci路径加一下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7368f5f
to
797c021
Compare
@@ -10,6 +10,7 @@ on: | |||
- 'components/finsh/**' | |||
- 'components/drivers/include/drivers/**' | |||
- 'components/drivers/clk/**' | |||
- 'components/drivers/audio/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下面的push: 路径也加一下
797c021
to
95dd784
Compare
Signed-off-by: 1078249029 <[email protected]>
95dd784
to
a1be047
Compare
@1078249029 以后提交 PR 时能将我添加为这些 doxygen 相关 PR 的审阅者吗? 另外我看这个 PR 是标记为 RFC 的,所以我理解还是 draft 阶段,如果不想理解被 merge,github 支持标记为 draft pr,参考 https://docs.github.com/zh/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests#draft-pull-requests |
我建议优先把 https://rt-thread.github.io/rt-thread/page_device_framework.html 相关的 API 的注释整理好,譬如 rt_device_find/rt_device_init 这些。否则你会发现 markdown 中有很多地方都在反复的写 rt_device_find 的注释,譬如 https://rt-thread.github.io/rt-thread/page_device_framework.html#autotoc_md254 和 https://rt-thread.github.io/rt-thread/page_device_audio.html#autotoc_md799。 这部分描述我添加到 #9424 (comment) 中了,备忘。 |
@1078249029 我补充了一些问题,不过由于这个 pr 已经被 merge了,所以我提了一个 issue:#10065,请看一下。 |
此外,我发现这个 PR 的 title 和 pr 的内容描述写得也是让人很迷惑,这个 pr 就是针对 driver/audio 的注释修改而已,感觉和 pr 的描述毫无关系。因为已经 merge 了看起来无法修改,建议以后 pr 时注意。 @1078249029 @supperthomas FYI。 |
@unicornx 这部分我会在完成audio注释内容后统一整理 |
@unicornx 我当时想的是用audio注释的编写作为整个doxygen文档编写的标准化流程,无论是之后的utest测试代码的编写还是当前的doxygen文档。没想到先被合并了。 |
Signed-off-by: 1078249029 <[email protected]>
Signed-off-by: 1078249029 <[email protected]>
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
根据#10046,标准化doxygen文档编写流程
你的解决方案是什么 (what is your solution)
目前doxygen文档编写流程还不成熟,遇到如下问题:
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up