[bsp/phytium]适配rtthread5.2版本 #10178

messigogogo · 2025-04-10T08:32:07Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

适配phytium芯片rtthread5.2版本，增加新驱动与模块。对原先驱动进行调整

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

BSP:

.config:

action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

rtthread 5.2适配 See merge request zhangyan1491/rt-thread!7

Copilot

Copilot reviewed 54 out of 65 changed files in this pull request and generated no comments.

Files not reviewed (11)

bsp/phytium/aarch32/.config: Language not supported
bsp/phytium/aarch32/configs/e2000d_demo_rtsmart: Language not supported
bsp/phytium/aarch32/configs/e2000d_demo_rtthread: Language not supported
bsp/phytium/aarch32/configs/e2000d_demo_rtthread_pusb2_dc: Language not supported
bsp/phytium/aarch32/configs/e2000q_demo_rtsmart: Language not supported
bsp/phytium/aarch32/configs/e2000q_demo_rtthread: Language not supported
bsp/phytium/aarch32/configs/phytium_pi_rtsmart: Language not supported
bsp/phytium/aarch32/configs/phytium_pi_rtthread: Language not supported
bsp/phytium/aarch32/configs/phytium_pi_rtthread_pusb2_hc: Language not supported
bsp/phytium/aarch32/makefile: Language not supported
bsp/phytium/aarch64/.config: Language not supported

Comments suppressed due to low confidence (2)

bsp/phytium/aarch32/rtconfig.h:71

The macro RT_USING_OVERFLOW_CHECK is defined in one section but appears to be removed in another diff hunk. Please ensure that its definition is applied consistently across the file to avoid potential configuration conflicts.

#define RT_USING_OVERFLOW_CHECK

bsp/phytium/aarch32/configs/phytium_pi_rtthread_pusb2_hc.h:345

A duplicate definition of RT_PAGE_MAX_ORDER is present in different memory management sections. Consider consolidating this definition to prevent potential conflicts and improve maintainability.

#define RT_PAGE_MAX_ORDER 11

supperthomas · 2025-04-10T11:32:50Z

请加一下ci

supperthomas · 2025-04-10T11:33:03Z

https://club.rt-thread.org/ask/article/a968b8e82fdc990b.html

BernardXiong · 2025-04-10T15:15:45Z

😢 是否可以不是刷config的模式？应该有更好的办法吧

messigogogo · 2025-04-11T01:38:49Z

Member
已添加

supperthomas · 2025-04-11T03:48:21Z

@sakumisu

cherryusb请帮忙review一下

sakumisu · 2025-04-11T06:03:28Z

cherryusb 部分没问题

supperthomas · 2025-04-11T06:36:24Z

.github/ALL_BSP_COMPILE.json

+    {
+      "RTT_BSP": "phytium_aarch64",
+      "RTT_TOOL_CHAIN": "sourcery-aarch64",
+      "SUB_RTT_BSP": [


请合并到上面的aarch64组中："RTT_BSP": "aarch64",

supperthomas · 2025-04-11T06:36:42Z

.github/ALL_BSP_COMPILE.json

+    },
+    {
+      "RTT_BSP": "phytium_aarch32",
+      "RTT_TOOL_CHAIN": "sourcery-arm",


放到该组中："RTT_BSP": "others_ft32_mm32_acm32",

supperthomas · 2025-04-11T06:37:56Z

bsp/phytium/aarch32/configs/e2000d_demo_rtthread_pusb2_dc.h

@@ -3,13 +3,72 @@

 /* RT-Thread Kernel */

+/* klibc options */
+


请参考：
https://club.rt-thread.org/ask/article/d273bbcd1f8779bc.html
和
https://club.rt-thread.org/ask/article/5c41835bb8ff9b41.html
中把Kconfig整合到yml中

您好，我目前的方案是在一个架构下支持多套Kconfig，比如在aarch64/configs目录下，包含了多个CPU的支持，使用时会拉取一套配置至aarch64/.config&rtconfig.h。这种结构可以适配您说的方案吗？

@supperthomas

您好，我目前的方案是在一个架构下支持多套Kconfig，比如在aarch64/configs目录下，包含了多个CPU的支持，使用时会拉取一套配置至aarch64/.config&rtconfig.h。这种结构可以适配您说的方案吗？

支持的，你可以直接使用scons --attach=e2000d_demo_rtsmart 你可以先加几个配置试试看。
比如先把.config和rtconfig.h 替换成你想要个的配置，然后执行menuconfig，然后按键盘d,然后把配置保存到yml中，试试。
参考链接：
https://club.rt-thread.org/ask/article/d273bbcd1f8779bc.html

你好，scons --attach=?我测试了没有问题，但另一个文档中bsp_buildings.yml，似乎没有其他开发板信息，是加在其他地方了吗？@supperthomas

感谢PR,
这个bsp_buildings.yml优化到：
https://github.com/RT-Thread/rt-thread/blob/master/.github/ALL_BSP_COMPILE.json
里面了，直接在json里面修改即可，我看你们有提PR，参考comment修改即可。

supperthomas · 2025-04-14T09:29:58Z

supperthomas · 2025-04-14T09:36:33Z

这边建议config的，先恢复，暂时不改，只修改json，让CI编译基本的，然后再起一个PR，单独处理config到yml中。另外那个PR会检查所有的config的编译情况，根据在ubuntu上执行scons. 另外一个PR会单独编译对应的bsp。

messigogogo · 2025-04-14T10:03:35Z

这边建议config的，先恢复，暂时不改，只修改json，让CI编译基本的，然后再起一个PR，单独处理config到yml中。另外那个PR会检查所有的config的编译情况，根据在ubuntu上执行scons. 另外一个PR会单独编译对应的bsp。

我回退了，先合入这个，然后我再提一个

supperthomas · 2025-04-14T11:08:11Z

bsp/phytium/aarch64/disassembly.txt

这个文件需要吗？不需要的话，可以删掉

supperthomas · 2025-04-14T11:14:41Z

@messigogogo 这个PR先合并了，后续尽快提交yml修复ci中的编译问题。

add RT_THREAD_CTRL_SET_PRIORITY add RT_THREAD_CTRL_SET_PRIORITY doxygen: cleanup and re-org files This patch contains two small changes, mainly to prepare for the next step of organizing the modules framework. The first change: move the files related to doxygen examples to `documentation/0.doxygen/example/` The second change: delete `documentation/0.doxygen/mainpage.h`, which is the mainpage of the old page. Now the new mainpage is `documentation/INDEX.md`, so the duplicate can be deleted. Signed-off-by: Chen Wang <[email protected]> [bsp/hpm5300evk]: 修复readme中的描述问题 (RT-Thread#10187) 1.bsp中描述路径boards不存在，只有board，并且路径中会包含openocd，把openocd路径去掉 2. 运行openocd发现cmsis-dap.cfg异常，使用ft2232.cfg可以正常烧入，修改readme 3. 添加download.bat脚本，方便下载 libcpu: aarch64: Fix NORMAL_NOCACHE_MEM attr (RT-Thread#10180) Signed-off-by: Cliff Chen <[email protected]> Signed-off-by: mouch6131 <[email protected]> Co-authored-by: Cliff Chen <[email protected]> Fixed an error by running scons --tartget=cmake under LINUX, RT-Thread#10113 (RT-Thread#10164) Fixed an error by running scons --tartget=cmake under LINUX, and associated issue RT-Thread#10113 [DM/FDT] Fix garble when booting Fix garble caused by empty implementation of earlycon series function in driver.If driver doesn't offer earlycon_id or rt_f dt_earlycon_id.setup function but open option, the checking of best_earlycon_id will failed. Signed-off-by: 1078249029 <[email protected]> [bsp/phytium]适配rtthread5.2版本 (RT-Thread#10178) * rtthread 5.2适配

messigogogogo added 2 commits April 10, 2025 08:14

rtthread 5.2适配

9fcc5de

Merge branch 'rtthread_5.2' into 'master'

d625772

rtthread 5.2适配 See merge request zhangyan1491/rt-thread!7

github-actions bot added BSP BSP: Phytium BSP related with Phytium Component component: drivers/usb component: drivers labels Apr 10, 2025

messigogogo added 3 commits April 10, 2025 16:34

qspi example

9e74676

qspi example

49340ce

format

516e30d

supperthomas requested a review from Copilot April 10, 2025 11:31

Copilot AI reviewed Apr 10, 2025

View reviewed changes

update

43289d2

messigogogo requested a review from supperthomas as a code owner April 11, 2025 01:37

github-actions bot added the action github action yml imporve label Apr 11, 2025

update

c45f691

supperthomas requested changes Apr 11, 2025

View reviewed changes

messigogogo force-pushed the master branch from eb94e6a to c45f691 Compare April 14, 2025 09:59

messigogogo added 2 commits April 14, 2025 18:02

update

cafd413

update

7da1821

supperthomas approved these changes Apr 14, 2025

View reviewed changes

bsp/phytium/aarch64/disassembly.txt

Copy link

Member

supperthomas Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件需要吗？不需要的话，可以删掉

supperthomas approved these changes Apr 14, 2025

View reviewed changes

supperthomas merged commit 3ebad06 into RT-Thread:master Apr 14, 2025
56 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bsp/phytium]适配rtthread5.2版本 #10178

[bsp/phytium]适配rtthread5.2版本 #10178

messigogogo commented Apr 10, 2025

Copilot AI left a comment

supperthomas commented Apr 10, 2025

supperthomas commented Apr 10, 2025

BernardXiong commented Apr 10, 2025

messigogogo commented Apr 11, 2025

supperthomas commented Apr 11, 2025 •

edited

Loading

sakumisu commented Apr 11, 2025

supperthomas Apr 11, 2025

supperthomas Apr 11, 2025

supperthomas Apr 11, 2025

messigogogo Apr 11, 2025 •

edited

Loading

messigogogo Apr 11, 2025

supperthomas Apr 11, 2025 •

edited

Loading

messigogogo Apr 14, 2025 •

edited

Loading

supperthomas Apr 14, 2025 •

edited

Loading

supperthomas commented Apr 14, 2025

supperthomas commented Apr 14, 2025

messigogogo commented Apr 14, 2025

supperthomas Apr 14, 2025

supperthomas commented Apr 14, 2025

[bsp/phytium]适配rtthread5.2版本 #10178

[bsp/phytium]适配rtthread5.2版本 #10178

Conversation

messigogogo commented Apr 10, 2025

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Copilot AI left a comment

Choose a reason for hiding this comment

supperthomas commented Apr 10, 2025

supperthomas commented Apr 10, 2025

BernardXiong commented Apr 10, 2025

messigogogo commented Apr 11, 2025

supperthomas commented Apr 11, 2025 • edited Loading

sakumisu commented Apr 11, 2025

supperthomas Apr 11, 2025

Choose a reason for hiding this comment

supperthomas Apr 11, 2025

Choose a reason for hiding this comment

supperthomas Apr 11, 2025

Choose a reason for hiding this comment

messigogogo Apr 11, 2025 • edited Loading

Choose a reason for hiding this comment

messigogogo Apr 11, 2025

Choose a reason for hiding this comment

supperthomas Apr 11, 2025 • edited Loading

Choose a reason for hiding this comment

messigogogo Apr 14, 2025 • edited Loading

Choose a reason for hiding this comment

supperthomas Apr 14, 2025 • edited Loading

Choose a reason for hiding this comment

supperthomas commented Apr 14, 2025

supperthomas commented Apr 14, 2025

messigogogo commented Apr 14, 2025

supperthomas Apr 14, 2025

Choose a reason for hiding this comment

supperthomas commented Apr 14, 2025

supperthomas commented Apr 11, 2025 •

edited

Loading

messigogogo Apr 11, 2025 •

edited

Loading

supperthomas Apr 11, 2025 •

edited

Loading

messigogogo Apr 14, 2025 •

edited

Loading

supperthomas Apr 14, 2025 •

edited

Loading