Skip to content

[libcpu/common] 修正对RV32E的支持,移除无用文件 #10339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

Yaochenger
Copy link
Contributor

@Yaochenger Yaochenger commented May 29, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

1.修正libcpu/common对RV32E的支持,RV32E不支持s2寄存器,修改为s1寄存器
2.移除无用文件,在RV32下中断管理器的支持较为丰富,所以该文件没有存在这里的必要,更多的是放在BSP中,且当前的RV32 BSP均未使用该文件

你的解决方案是什么 (what is your solution)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added Arch: RISC-V BSP related with risc-v libcpu labels May 29, 2025
lw s2, 0(s0)
beqz s2, spurious_interrupt
lw s1, 0(s0)
beqz s1, spurious_interrupt
Copy link
Member

@aozima aozima May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里更换为S1的原理是啥?最好能在commit中说明。

另外技术类修改,和文件的增减,最好分开commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已拆分为2个commit并描述修改的原因

@Rbb666 Rbb666 merged commit f4e619a into RT-Thread:master May 30, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: RISC-V BSP related with risc-v libcpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants