消除usb结构体gcc编译时的相关警告 #1744
Merged
消除usb结构体gcc编译时的相关警告 #1744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lymzzyh
suggested changes
Aug 30, 2018
| @@ -1865,19 +1864,6 @@ static rt_err_t rt_usbd_ep_assign(udevice_t device, uep_t ep) | |||
| return -RT_ERROR; | |||
| } | |||
|
|
|||
| static rt_err_t rt_usbd_ep_unassign(udevice_t device, uep_t ep) | |||
There was a problem hiding this comment.
这个要预留下来，是有可能用到的 当有多个config的时候在切换config的时候是会用到的，不过目前还没有完善这个功能
There was a problem hiding this comment.
按照BernardXiong的方法先把static属性去掉了
2. 修改一处存在多余括号问题. armclang有警告发出.
lymzzyh
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
消除usb结构体gcc编译时的相关警告,这些警告在更严格的armclang编译器中可能是错.为减少移植的手动更改数量,消除这些警告.
1)消除usb结构体定义警告.改为规范的结构体定义,消除警告
2)消除函数_interface_handler中,变量设置但未使用的警告.删除这些变量,消除警告
3)消除_cbw_verify函数中连续多次使用&&和||的警告,&&优先级高于||,加括号消除警告
4)删除未用函数rt_usbd_ep_unassign,消除函数未用警告