-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[armclang] 使用__clang__代替__CLANG_ARM #5451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cndabai 老马麻烦用KEIL AC6测试一下,我没有条件测试AC6 ARMCLANG |
满老师,刚测了俩BSP,没发现问题的 |
测试下 clang 的宏生效不 |
|
nice |
ok我修一下 |
+2 |
This was referenced Jul 9, 2022
mysterywolf
added a commit
to mysterywolf/rt-thread
that referenced
this pull request
Aug 15, 2022
9 tasks
Guozhanxin
pushed a commit
that referenced
this pull request
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
移除rtdef.h中的__CLANG_ARM宏定义
用__clang__代替__CLANG_ARM,__CLANG_ARM是我们在rtdef.h里自己定义的宏,使用受限,__clang__是标准的全局宏。
用#ifdef __ARMCC_VERSION代替#if defined(__CC_ARM) || defined(__CLANG_ARM)
#5342 (comment)
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up