-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pin][5.0.0] 修正pin框架数据类型使用不当 #6934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysterywolf
requested changes
Feb 18, 2023
mysterywolf
reviewed
Feb 18, 2023
有没有什么好处,没好处的话,这么改,感觉没必要。
|
解决了数据类型混乱的问题,历史问题。5.0.0不考虑向前兼容性。但是本修改对前向兼容影响不大,都是本仓库自己内部的问题。 |
数据类型混乱是什么问题?会造成什么后果吗? |
问题主要为:
|
Guozhanxin
reviewed
Feb 21, 2023
mysterywolf
requested changes
Feb 23, 2023
mysterywolf
approved these changes
Feb 24, 2023
Guozhanxin
approved these changes
Feb 27, 2023
Closed
charlown
added a commit
to charlown/rt-thread
that referenced
this pull request
Mar 7, 2023
…#6934), rtc(get_secs/set_secs RT-Thread#5772),spi(RT-Thread#6937)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
STM32
为什么提交这份PR (why to submit this PR)
[修改pin数据类型]
你的解决方案是什么 (what is your solution)
[修改pin数据类型]
在什么测试环境下测试通过 (what is the test environment)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up