Skip to content

[kernel][bsp][HUST_CSE]:设计新的消息接收函数,可以返回消息的实际大小 #7256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 40 commits into from

Conversation

xin-zheqi
Copy link
Contributor

@xin-zheqi xin-zheqi commented Apr 15, 2023

cloese #5730

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

消息队列接口设计不合理,rt_mq_recv不能传出消息的实际大小

你的解决方案是什么 (what is your solution)

编写一个新的函数可以返回消息的实际大小

在什么测试环境下测试通过 (what is the test environment)

ALL
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf mysterywolf added the University: HUST IoTS&P Lab 华中科技大学网络空间安全学院 label Apr 15, 2023
@mysterywolf
Copy link
Member

直接用rt_mq_recv函数即可,返回值改成rt_ssize_t >=0表示正确并返回实际长度, <0返回错误码

@xin-zheqi
Copy link
Contributor Author

rt_size_t 是 unsigned long 类型
rt_err_t 是long类型
可以继续沿用 rt_err_t

@mysterywolf
Copy link
Member

mysterywolf commented Apr 16, 2023

不是rt_size_t 是rt_ssize_t,两个s。 rt_ssize_t是有符号类型,在4.1.1版本之后新加的一个,就是为了这种即返回长度又可能返回错误码的情况准备的

@mysterywolf
Copy link
Member

@Guozhanxin 郭老师麻烦review一下这个PR呗 我觉得没啥问题了

@supperthomas supperthomas changed the title [HUST_CSE]:设计新的消息接收函数,可以返回消息的实际大小 [kernel][bsp][example][HUST_CSE]:设计新的消息接收函数,可以返回消息的实际大小 May 4, 2023
@supperthomas supperthomas added BSP Kernel PR has src relate code labels May 4, 2023
@mysterywolf
Copy link
Member

请往我邮箱里随便发点什么 [email protected]

@mysterywolf mysterywolf changed the title [kernel][bsp][example][HUST_CSE]:设计新的消息接收函数,可以返回消息的实际大小 [kernel][bsp][HUST_CSE]:设计新的消息接收函数,可以返回消息的实际大小 Jun 5, 2023
@mysterywolf mysterywolf added +1 Agree +1 +2 Agree +2 in progress PR/issue in progress. and removed +1 Agree +1 +2 Agree +2 labels Jun 6, 2023
@mysterywolf mysterywolf removed the request for review from BernardXiong June 6, 2023 17:56
@mysterywolf mysterywolf marked this pull request as draft June 7, 2023 03:55
@mysterywolf
Copy link
Member

33f550c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP in progress PR/issue in progress. Kernel PR has src relate code University: HUST IoTS&P Lab 华中科技大学网络空间安全学院
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants