Skip to content

[bsp][phytium]适配rt-thread5.0.0 版本 #7441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 11, 2023

Conversation

ssd4561
Copy link
Contributor

@ssd4561 ssd4561 commented May 4, 2023

拉取/合并请求描述:(PR description)

[

  • phytium嵌入式芯片适配 rt-thread smart、aarch32、aarch64 等特性
  • 新增qspi、can、spi 驱动
  • 新增新的编译链说明

为什么提交这份PR (why to submit this PR)

在什么测试环境下测试通过 (what is the test environment)

在phytium demo开发板上测试通过
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@BernardXiong
Copy link
Member

BernardXiong commented May 5, 2023

这部分还请多看看,如果是standalone的库,可以做忽略。

@ssd4561
Copy link
Contributor Author

ssd4561 commented May 6, 2023

这部分还请多看看,如果是standalone的库,可以做忽略。

已经解决formatting的问题

@mysterywolf mysterywolf added the +1 Agree +1 label May 10, 2023
@mysterywolf mysterywolf added the +2 Agree +2 label May 10, 2023
@BernardXiong BernardXiong merged commit 50a4e8c into RT-Thread:master May 11, 2023
@babboys
Copy link
Contributor

babboys commented May 16, 2023

@ssd4561 libcpu\arm\cortex-a\start_gcc.S 这个文件下,这个有个地方实现有点疑问。

.weak rt_asm_cpu_id 
rt_asm_cpu_id:
    mov r9, lr
    mrc p15, 0, r0, c0, c0, 5
    and r0, r0, #0xf
    mov lr, r9

以上代码的结尾,mov lr, r9为什么不是bx lr呢,外部如果没有实现rt_asm_cpu_id 函数的情况下,这个地方会不会出现死循环。

@aozima
Copy link
Member

aozima commented May 16, 2023

@babboys #7515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP +1 Agree +1 +2 Agree +2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants