Skip to content

[CI] Added feature to filter out files that do not require cppch… #7462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

dejavudwh
Copy link
Contributor

@dejavudwh dejavudwh commented May 8, 2023

…eck according to ignore_format.yml

拉取/合并请求描述:(PR description)

添加了根据ignore_format.yml的ignore_files属性过滤掉不需要cppcheck的文件,考虑到可能需要更细粒度的过滤,所以由issue中提到的过滤文件夹实现为过滤文件

为什么提交这份PR (why to submit this PR)

#7458

你的解决方案是什么 (what is your solution)

  1. 通过yq包实现yml文件的解析
  2. 循环遍历所有修改过的文件,判断最后一个\之后是否存在需要过滤的文件名

在什么测试环境下测试通过 (what is the test environment)

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf mysterywolf requested a review from supperthomas May 9, 2023 01:54
@supperthomas supperthomas changed the title [feature] Added feature to filter out files that do not require cppch… [CI] Added feature to filter out files that do not require cppch… May 9, 2023
@supperthomas
Copy link
Member

supperthomas commented May 9, 2023

感谢PR。这个PR大概思路是对的。
有个信息需要知道,.ignore_format.yml 这个文件是散落在bsp目录下面的,需要遍历bsp下面
https://github.com/RT-Thread/rt-thread/blob/master/bsp/bouffalo_lab/libraries/bl_mcu_sdk/.ignore_format.yml
建议搞个python脚本放到tools里面生成所有需要忽略的目录。

@supperthomas supperthomas added the action github action yml imporve label May 9, 2023
Copy link
Member

@supperthomas supperthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action github action yml imporve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants