Skip to content

[libcpu/arm64] dealing with mem region out of kernel space #8847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2024

Conversation

polarvid
Copy link
Contributor

@polarvid polarvid commented Apr 23, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Relates to #8846

Dealing with mem region out of kernel space.

你的解决方案是什么 (what is your solution)

  • Fix parameter checking in _out_of_range() that NULL is excluded for fixed mapping
  • Split page install with a deferred stage to avoid mapping over ARCH_EARLY_MAP_SIZE

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

- Fix parameter checking in _out_of_range() that NULL is excluded for
  fixed mapping
- Split page install with a deferred stage to avoid mapping over
  ARCH_EARLY_MAP_SIZE

Signed-off-by: Shell <[email protected]>
@BernardXiong
Copy link
Member

也可能会影响到启动速度?可以对启动速度留个心眼,因为这个也是关键性指标的。

@polarvid polarvid marked this pull request as ready for review April 24, 2024 05:58
@polarvid polarvid requested a review from BernardXiong as a code owner April 24, 2024 05:58
@polarvid
Copy link
Contributor Author

image

这个 CI 应该是 package 的问题,和本 PR 无关。

@mysterywolf mysterywolf reopened this Apr 24, 2024
@polarvid
Copy link
Contributor Author

也可能会影响到启动速度?可以对启动速度留个心眼,因为这个也是关键性指标的。

这里主要是把原本一次完成的内存初始化拆成两个部分,避免超过早期映射 1 GB 空间的限制。比如开发板有 8GB DDR,这个会把初始映射不能访问的 page 初始化延后。否则初始化完成就有可能分配到这些地址,触发访问异常。从算法上来说两次初始化需要遍历的内存区域没有什么区别。

@BernardXiong BernardXiong merged commit 9ba6cec into RT-Thread:master May 8, 2024
80 of 81 checks passed
sp-cai pushed a commit to sp-cai/rt-thread that referenced this pull request May 8, 2024
…#8847)

* [ofw] dealing with mem region out of kernel space

- Fix parameter checking in _out_of_range() that NULL is excluded for
  fixed mapping
- Split page install with a deferred stage to avoid mapping over
  ARCH_EARLY_MAP_SIZE

Signed-off-by: Shell <[email protected]>

* fixup: restrict vstart for using of RT_NULL

---------

Signed-off-by: Shell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants