Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lwp]list_process can print tid #8991

Merged
merged 8 commits into from
May 31, 2024
Merged

[lwp]list_process can print tid #8991

merged 8 commits into from
May 31, 2024

Conversation

rcitach
Copy link
Contributor

@rcitach rcitach commented May 27, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

list_process can print tid
image

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@rcitach rcitach requested a review from BernardXiong as a code owner May 27, 2024 02:00
@BernardXiong
Copy link
Member

BernardXiong commented May 28, 2024

TID和PID是相同的,有必要同时输出吗?唔,应该一个进程内多个线程,这个TID就应该不一样了吧,也给份截图例子?

@rcitach
Copy link
Contributor Author

rcitach commented May 28, 2024

TID和PID是相同的,有必要同时输出吗?唔,应该一个进程内多个线程,这个TID就应该不一样了吧,也给份截图例子?

是的,一个进程内多个线程这种场景TID的值是不一样的。
image

@BernardXiong
Copy link
Member

是否可以把cmd放最后面,这样可以尝试显示更全的命令行

@rcitach
Copy link
Contributor Author

rcitach commented May 29, 2024

是否可以把cmd放最后面,这样可以尝试显示更全的命令行

好的,在再修改一下

@Rbb666 Rbb666 self-requested a review May 31, 2024 03:49
@rcitach
Copy link
Contributor Author

rcitach commented May 31, 2024

已完成修改:
image
不过值得提出的一点就是,cmd命令长度主要还是取决于宏 RT_NAME_MAX 定义的长度。

@Rbb666
Copy link
Member

Rbb666 commented May 31, 2024

@BernardXiong 没问题就合并啦

@BernardXiong BernardXiong merged commit 85b428d into RT-Thread:master May 31, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants