-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[timer]add all soft timer config #9048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多加测试用例,把timer相关corner case都尽可能覆盖
fb6b815
to
4f4f8fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以把 utest 加到 CI 里面
https://github.com/RT-Thread/rt-thread/actions/runs/9493849409/job/26163220310?pr=9048 里面jobs的kernel/timer就是吧 |
* add all soft timer * update wq * add timer test * shield LOG_D
@@ -12,6 +12,16 @@ | |||
#include <stdlib.h> | |||
#include "utest.h" | |||
|
|||
#undef uassert_true | |||
#define uassert_true(value) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加这个的目的是什么呀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
串口打印耗时较长,会影响测试结果,之前的用例也是只有错误时才打印
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
添加选项,开启该选项所有timer均在线程环境执行
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up