Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libcpu][aarch64]memory setup using memblock #9092

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

zmshahaha
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@zmshahaha zmshahaha requested a review from BernardXiong as a code owner June 24, 2024 08:01
@zmshahaha zmshahaha force-pushed the mmsetup branch 2 times, most recently from 2c08624 to 1eda647 Compare June 24, 2024 09:02
@zmshahaha zmshahaha requested a review from Guozhanxin as a code owner June 24, 2024 09:02
@zmshahaha zmshahaha force-pushed the mmsetup branch 2 times, most recently from ba589c9 to bf803b5 Compare June 24, 2024 09:16
@zmshahaha zmshahaha force-pushed the mmsetup branch 2 times, most recently from 7e319bf to 8942c52 Compare June 24, 2024 09:35
@BernardXiong BernardXiong requested a review from polarvid June 24, 2024 13:36
@polarvid polarvid added the +1 Agree +1 label Jun 25, 2024
@polarvid
Copy link
Contributor

记得修一下 CI

image

@zmshahaha zmshahaha marked this pull request as draft June 25, 2024 02:38
@zmshahaha zmshahaha force-pushed the mmsetup branch 2 times, most recently from 67979fe to 3ef74e0 Compare June 25, 2024 06:21
@zmshahaha zmshahaha marked this pull request as ready for review June 25, 2024 06:25
@zmshahaha zmshahaha force-pushed the mmsetup branch 2 times, most recently from 4148e77 to a0da93e Compare June 25, 2024 06:48
@BernardXiong BernardXiong merged commit b785ef9 into RT-Thread:master Jun 26, 2024
47 checks passed
@zmshahaha zmshahaha deleted the mmsetup branch July 4, 2024 08:49
messigogogo pushed a commit to messigogogo/rt-thread that referenced this pull request Jul 22, 2024
* memory setup using memblock

* map pages later
zmshahaha added a commit to zmshahaha/rt-thread that referenced this pull request Sep 12, 2024
* memory setup using memblock

* map pages later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+1 Agree +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants