Skip to content

[libcpu][setup]fix fdt_ptr error #9138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

zmshahaha
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

之前fdt_ptr错误指向设备树的物理地址,此处修正为虚拟地址

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@BernardXiong
Copy link
Member

之前都没怎么使用到吗?或者一个相对基本,完善些的测试用例有吗

@zmshahaha
Copy link
Contributor Author

zmshahaha commented Jul 4, 2024

换预留内存算法这里漏加了,测试用例utest里有。这个因为没影响到系统正常启动所以未及时发现

如果说是测rt_hw_common_setup,这个api是没法在系统启动后调用,只能用各种板子测试启动是否能够成功。目前在已支持设备树的aarch64平台都可以启动

@BernardXiong BernardXiong requested a review from polarvid July 4, 2024 08:51
@BernardXiong BernardXiong merged commit 23fc7bf into RT-Thread:master Jul 16, 2024
43 checks passed
@zmshahaha zmshahaha deleted the fdtptr branch July 17, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants