Bugfix/fix weak handle trap in riscv common crash rv64 trap handling #9189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added weak handle_trap implementation Signed-off-by: Fan YANG <[email protected]>
- removed weak handle_trap function from trap_common.c Signed-off-by: Fan YANG <[email protected]>
unicornx
reviewed
Jul 15, 2024
| @@ -302,3 +302,10 @@ void trap_entry(void) | |||
| write_fcsr(fcsr); | |||
| #endif | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
有没有抽象一个公共文件就好了，我看你写了 N 个 ;-)
There was a problem hiding this comment.
我们下一版BSP发布的时候再统一更新一下吧，这版暂时就先这样了
BernardXiong
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
解决 Issue# #8978 中的问题
你的解决方案是什么 (what is your solution)
移除 在trap_common.c 中的 weak handle_trap 实现，暂时将这个handle_trap 弱实现放到先楫的BSP包里。
请提供验证的bsp和config (provide the config and bsp)
BSP:
hpm6750evkmini
hpm6750evk
hpm6750evk2
hpm6300evk
hpm6200evk
hpm5300evk
hpm5301evklite
hpm6800evk
.config:
action:
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up