Skip to content

[utest] add smp testcases #9356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[utest] add smp testcases #9356

merged 2 commits into from
Sep 3, 2024

Conversation

Yaochenger
Copy link
Contributor

@Yaochenger Yaochenger commented Aug 27, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

添加testcases\kernel\smp测试用例

你的解决方案是什么 (what is your solution)

1.smp spinlock测试用例
2.smp 绑核亲和力与线程优先级的测试用例
3.smp 线程抢占测试用例
4.smp 将线程分配至空闲核测试用例
5.smp 中断优先级设置测试用例

请提供验证的bsp和config (provide the config and bsp)

bsp\qemu-vexpress-a9

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@Yaochenger Yaochenger requested a review from Rbb666 as a code owner August 27, 2024 09:19
@Rbb666 Rbb666 requested review from polarvid and mysterywolf and removed request for mysterywolf August 27, 2024 09:20
@Rbb666
Copy link
Member

Rbb666 commented Aug 28, 2024

@polarvid SMP相关的测试用例,麻烦帮忙review下


/* Number of thread runs */
static int run_num = 100;
#define THREAD_STACK_SIZE 1024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议用 Kconfig 里的 UTEST stack size,而不是测试用例里面又定义一个。跨架构的时候这些定义基本跑不通。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议用 Kconfig 里的 UTEST stack size,而不是测试用例里面又定义一个。跨架构的时候这些定义基本跑不通。

已采纳

@Yaochenger Yaochenger requested a review from polarvid September 2, 2024 03:41
@Rbb666 Rbb666 merged commit 5d4f819 into RT-Thread:master Sep 3, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants