-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libcpu/aarch64]atomic实现修改 #9364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
这个挺早好像就有反馈说有问题了。不过 arm64 hw_atomic 不是我这维护的,平时也不用,所以没关注。 关于 PR 修复,建议是使能 HW_ATOMIC 关闭 STDC,然后通过 unittest case 验证一下。这部分的用例是有的。 |
e91e6ed
to
0e3c4bd
Compare
配置的修改能拆出来吗?在这个 PR 下好像无关,有点乱了。 |
10e2e71
to
3f5aed7
Compare
关掉了,只保留了atomic_aarch64的修改 |
polarvid
suggested changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
polarvid
approved these changes
Sep 3, 2024
mysterywolf
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
在e9b683d 的提交中规范了atomic的实现方式,原本phytium bsp的默认配置同时打开了RT_USING_STDC_ATOMIC/RT_USING_HW_ATOMIC, 关闭后RT_USING_STDC_ATOMIC发现内核不能正常启动,查明原因是libcpu\aarch64\common\atomic_aarch64.c 中rt_hw_atomic_compare_exchange_strong函数逻辑有误,请仔细检查
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up