-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[utest]fix race in mutex tc & add recurse lock tc #9365
Conversation
81494b6
to
c860cd2
Compare
c860cd2
to
8d631f3
Compare
CI 除了格式检查之外,貌似有个检查没过 |
rt_thread_mdelay(1000); | ||
while (_sync_flag != 3) | ||
{ | ||
rt_thread_mdelay(1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个delay 确认一下 在QEMU仿真世界里是否需要这么长的时间?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最好是全部换成 IPC,用时延的用例都不怎么靠谱。经常是换个平台就跑不起来了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
这个pr依赖于 #9337 ,这个pr修了一个线程对一个mutex两次take,退出时没有完全释放的bug,这个pr有依赖 delay 1000的已改成delay10 |
8d631f3
to
de398b4
Compare
de398b4
to
f0461e3
Compare
@zmshahaha CI 需要修一下,把ROM扩大 或者改成-O2 |
6003ac9
to
f38c87c
Compare
f38c87c
to
4080834
Compare
已修 |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up